[Trac-tickets] Re: [The Trac Project] #1092: Browser gets None from fs.revision_prop(LOG)

[The Trac Project]

#1092: Browser gets None from fs.revision_prop(LOG)
---------------------+------------------------------------------------------
       Id:  1092     |      Status:  new                     
Component:  browser  |    Modified:  Wed Mar  2 18:54:15 2005
 Severity:  normal   |   Milestone:                          
 Priority:  normal   |     Version:  0.8                     
    Owner:  jonas    |    Reporter:  bkc at murkworks.com       
---------------------+------------------------------------------------------
Changes (by cmlenz):

  * keywords:  NoneType  =>

Old description:

> It looks like Browser.py fails because this line (about line 89 in
> Browser.py) returns None
>
> change = svn.fs.revision_prop(self.fs_ptr, created_rev,
>    svn.util.SVN_PROP_REVISION_LOG,
>    self.pool)
>
> I'm running subversion 1.1.2 on RHEL3 (and a damn nightmare it was
> getting python bindings to work)
>
> Anyway, 'change' is None in some cases, generating this traceback:
>
> Traceback (most recent call last):
>   File "/usr/local/lib/python2.3/site-packages/trac/core.py", line 525,
> in cgi_start
>     real_cgi_start()
>   File "/usr/local/lib/python2.3/site-packages/trac/core.py", line 520,
> in real_cgi_start
>     dispatch_request(path_info, args, req, env)
>   File "/usr/local/lib/python2.3/site-packages/trac/core.py", line 435,
> in dispatch_request
>     module.run()
>   File "/usr/local/lib/python2.3/site-packages/trac/Module.py", line 44,
> in run
>     self.render()
>   File "/usr/local/lib/python2.3/site-packages/trac/Browser.py", line
> 172, in render
>     info = self.get_info(path, rev, rev_specified)
>   File "/usr/local/lib/python2.3/site-packages/trac/Browser.py", line 92,
> in get_info
>     item = {
>   File "/usr/local/lib/python2.3/site-packages/trac/util.py", line 62, in
> wiki_escape_newline
>     return text.replace(os.linesep, '[[BR]]' + os.linesep)
> AttributeError: 'NoneType' object has no attribute 'replace'
>
> My temporary fix is this:
>
>  change = svn.fs.revision_prop(self.fs_ptr, created_rev,
>     svn.util.SVN_PROP_REVISION_LOG,
>     self.pool) or ''

New description:

 It looks like Browser.py fails because this line (about line 89 in
 Browser.py) returns None

 {{{
 change = svn.fs.revision_prop(self.fs_ptr, created_rev,
    svn.util.SVN_PROP_REVISION_LOG,
    self.pool)
 }}}

 I'm running subversion 1.1.2 on RHEL3 (and a damn nightmare it was getting
 python bindings to work)

 Anyway, 'change' is None in some cases, generating this traceback:

 {{{
 Traceback (most recent call last):
   File "/usr/local/lib/python2.3/site-packages/trac/core.py", line 525, in
 cgi_start
     real_cgi_start()
   File "/usr/local/lib/python2.3/site-packages/trac/core.py", line 520, in
 real_cgi_start
     dispatch_request(path_info, args, req, env)
   File "/usr/local/lib/python2.3/site-packages/trac/core.py", line 435, in
 dispatch_request
     module.run()
   File "/usr/local/lib/python2.3/site-packages/trac/Module.py", line 44,
 in run
     self.render()
   File "/usr/local/lib/python2.3/site-packages/trac/Browser.py", line 172,
 in render
     info = self.get_info(path, rev, rev_specified)
   File "/usr/local/lib/python2.3/site-packages/trac/Browser.py", line 92,
 in get_info
     item = {
   File "/usr/local/lib/python2.3/site-packages/trac/util.py", line 62, in
 wiki_escape_newline
     return text.replace(os.linesep, '[[BR]]' + os.linesep)
 AttributeError: 'NoneType' object has no attribute 'replace'
 }}}

 My temporary fix is this:

 {{{
  change = svn.fs.revision_prop(self.fs_ptr, created_rev,
     svn.util.SVN_PROP_REVISION_LOG,
     self.pool) or ''
 }}}

Comment:

 (Made the code snippets and traceback in the description readable)

-- 
Ticket URL: <http://projects.edgewall.com/trac/ticket/1092>
The Trac Project <>