[Trac-tickets] Re: [The Trac Project] #2028: Integrate anydiff branch in the trunk

[The Trac Project]

#2028: Integrate anydiff branch in the trunk
----------------------------+-----------------------------------------------
 Reporter:  cboos           |        Owner:  cboos   
     Type:  task            |       Status:  assigned
 Priority:  high            |    Milestone:  1.0     
Component:  changeset view  |      Version:  devel   
 Severity:  major           |   Resolution:          
 Keywords:  branch          |  
----------------------------+-----------------------------------------------
Comment (by cmlenz):

 Okay, a couple of initial comments, without having looked at the code very
 closely:
  1. Is there a reason that the radio buttons in the revision log are layed
 out different from those in the wiki page history? Personally, I prefer
 the wiki version because it seems visually cleaner (less clutter).
  2. The placement of the top "View changes" button on the revision log
 page is bad: it is too far away from the table to make any intuitive
 sense. Also, this is related to #2095. For now, I'd suggest removing the
 top button and addressing the control redundancy issue later.
  3. Performing a diff from the form for arbitrary diffs delivers a page
 via POST, which is thus not bookmarkable, and will warn about reloading
 etc. There should be either a redirect, or better, simply use a GET-based
 form in the first place.
  4. The omission of the ''View changes'' button from the root of the
 repository seems like a fairly arbitrary decision. What's the rationale?
  5. I'm somewhat worried that the additional diff support can be used to
 request '''huge''' pages that are pretty expensive to generate, and thus
 be a good candidate for DOS attacks. Any ideas?
  6. It should be ''Latest change'' instead of ''Last change''.
  7. The heading of the diff page can easily become huge for a long path.
 Not sure what can be done here, but somehow they need to be less verbose,
 probably by moving some of the information into the content area.

-- 
Ticket URL: <http://projects.edgewall.com/trac/ticket/2028>
The Trac Project <http://trac.edgewall.com/>