[Trac-tickets] Re: [The Trac Project] #2012: PatchRenderer does not render chunk separator

[The Trac Project]

#2012: PatchRenderer does not render chunk separator
-----------------------------------------------+----------------------------
 Reporter:  Shunichi Goto <gotoh at taiyo.co.jp>  |        Owner:  cboos   
     Type:  defect                             |       Status:  assigned
 Priority:  normal                             |    Milestone:          
Component:  wiki                               |      Version:  devel   
 Severity:  minor                              |   Resolution:          
 Keywords:                                     |  
-----------------------------------------------+----------------------------
Changes (by cboos):

  * status:  new => assigned
  * severity:  normal => minor
  * owner:  jonas => cboos

Comment:

 Also, the `PatchRenderer` shouldn't be used at all
 when used in a wiki text for which the source is not available
 (i.e. in the ticket description or in ticket comments),
 as it's impossible to get the actual diff source in that case.

 But this would require an API change,
 `IHTMLPreviewRenderer.get_quality_ratio`
 would have to know about the context of use
 (add an optional `context` argument?).

 Note that I see additional benefits for such a change,
 related to the idea of using Mimeview renderers in order
 to show svn:properties in the browser (see #1601 and #1947):
 different renderers could be used depending on where the
 property is shown (either the list of properties for
 the current path or in additional custom column #1601).

-- 
Ticket URL: <http://projects.edgewall.com/trac/ticket/2012>
The Trac Project <http://trac.edgewall.com/>