[Trac-tickets] Re: [The Trac Project] #1999: Traceback in Apache error log

[The Trac Project]

#1999: Traceback in Apache error log
---------------------------------+------------------------------------------
 Reporter:  sam at bulix.org        |        Owner:  cmlenz  
     Type:  defect               |       Status:  assigned
 Priority:  low                  |    Milestone:  0.9     
Component:  general              |      Version:  devel   
 Severity:  minor                |   Resolution:          
 Keywords:  traceback error log  |  
---------------------------------+------------------------------------------
Comment (by cmlenz):

 I think the following change would get rid of these errors:

 {{{
 #!diff
 Index: trac/web/main.py
 ===================================================================
 --- trac/web/main.py    (revision 2251)
 +++ trac/web/main.py    (working copy)
 @@ -246,13 +246,17 @@
          if env and env.log:
              env.log.error('Failed to render pretty error page: %s', e2,
                            exc_info=True)
 -        req.send_response(500)
 -        req.send_header('Content-Type', 'text/plain')
 -        req.end_headers()
 -        req.write('Oops...\n\nTrac detected an internal error:\n\n')
 -        req.write(str(e))
 -        req.write('\n')
 -        req.write(tb.getvalue())
 +        try:
 +            req.send_response(500)
 +            req.send_header('Content-Type', 'text/plain')
 +            req.end_headers()
 +            req.write('Oops...\n\nTrac detected an internal error:\n\n')
 +            req.write(str(e))
 +            req.write('\n')
 +            req.write(tb.getvalue())
 +        except IOError:
 +            # Cannot send response, but the error has hopefully been
 logged
 +            pass

  def send_project_index(req, options, env_paths=None):
      from trac.web.clearsilver import HDFWrapper
 }}}

-- 
Ticket URL: <http://projects.edgewall.com/trac/ticket/1999>
The Trac Project <http://trac.edgewall.com/>