[Trac-tickets] Re: [The Trac Project] #2346: Timeline should handle being unable to contact subversion better

[The Trac Project]

#2346: Timeline should handle being unable to contact subversion better
------------------------------+---------------------------------------------
 Reporter:  chris at growl.info  |        Owner:  cboos   
     Type:  defect            |       Status:  assigned
 Priority:  normal            |    Milestone:  0.9.3   
Component:  timeline          |      Version:  0.9     
 Severity:  minor             |   Resolution:          
 Keywords:                    |  
------------------------------+---------------------------------------------
Changes (by cboos):

  * status:  new => assigned
  * component:  general => timeline

Comment:

 What about this?
 {{{
 #!diff
 Index: trac/versioncontrol/web_ui/changeset.py
 ===================================================================
 --- trac/versioncontrol/web_ui/changeset.py     (revision 2707)
 +++ trac/versioncontrol/web_ui/changeset.py     (working copy)
 @@ -101,8 +101,14 @@
      # ITimelineEventProvider methods

      def get_timeline_filters(self, req):
 -        if req.perm.has_permission('CHANGESET_VIEW'):
 -            yield ('changeset', 'Repository checkins')
 +        if req.perm.has_permission('CHANGESET_VIEW'):
 +            # repository unavailability shouldn't affect other event
 providers
 +            try:
 +                self.env.get_repository()
 +                yield ('changeset', 'Repository checkins')
 +            except TracError, e:
 +                yield ('changeset', '(Repository temporarily
 unavailable)',
 +                       False)

      def get_timeline_events(self, req, start, stop, filters):
          if 'changeset' in filters:
 }}}

-- 
Ticket URL: <http://projects.edgewall.com/trac/ticket/2346>
The Trac Project <http://trac.edgewall.com/>