[Trac-tickets] Re: [The Trac Project] #2006: broken images and attachments. SSL related.

[The Trac Project]

#2006: broken images and attachments. SSL related.
-------------------------------------------------+--------------------------
 Reporter:  tiger at tadol.net                      |        Owner:  jonas
     Type:  defect                               |       Status:  new  
 Priority:  normal                               |    Milestone:  0.9.3
Component:  general                              |      Version:  devel
 Severity:  normal                               |   Resolution:       
 Keywords:  https ssl broken images attachments  |  
-------------------------------------------------+--------------------------
Comment (by markus):

 I'm running TracCgi on IIS in https mode myself and have never seen this
 reported behavior (as I already said above).

 To me this seems like it has nothing to do with SSL but with TracCgi and
 Apache. You can find many error reports about a race condition in Apache
 when the Browser sends an `Is-Modified-Since` header.

 So, I'd rather try to speed up the response header transaction than remove
 the `Last-Modified` header part. You may try the following patch below:

 {{{
 #!diff
 Index: trac/web/cgi_frontend.py
 ===================================================================
 --- trac/web/cgi_frontend.py    (revision 2721)
 +++ trac/web/cgi_frontend.py    (working copy)
 @@ -70,6 +70,9 @@
      def write(self, data):
          return self.__output.write(data)

 +    def flush(self):
 +        return self.__output.flush()
 +
      def get_header(self, name):
          return self.__environ.get('HTTP_' + re.sub('-', '_',
 name.upper()))

 @@ -81,6 +84,7 @@

      def end_headers(self):
          self.write('\r\n')
 +        self.flush()


  class TracFieldStorage(cgi.FieldStorage):
 }}}

-- 
Ticket URL: <http://projects.edgewall.com/trac/ticket/2006>
The Trac Project <http://trac.edgewall.com/>