[Trac-tickets] Re: [The Trac Project] #3361: changes in notification cause breakage in email2trac

[The Trac Project]

#3361: changes in notification cause breakage in email2trac
-------------------------------------+--------------------------------------
 Reporter:  micah at riseup.net         |        Owner:  eblot   
     Type:  defect                   |       Status:  assigned
 Priority:  normal                   |    Milestone:          
Component:  ticket system            |      Version:  devel   
 Severity:  major                    |   Resolution:          
 Keywords:  notification email2trac  |  
-------------------------------------+--------------------------------------
Comment (by cmlenz):

 Replying to [comment:3 cboos]:
 > The notify method signature has changed, it now takes a `req` argument:
 > {{{
 > #!python
 > def notify(self, ticket, req, newticket=True, modtime=0):
 > }}}

 Which, BTW, I'd really like to change back. The email notifications should
 '''not''' require a HTTP request object. They should use the `base_url` of
 the Trac environment (`env.abs_href` or `env.base_url`) even if there's a
 different `Host` header in the request. In the future (0.11-ish) we should
 make email notifications '''require''' that option to be set in TracIni.

-- 
Ticket URL: <http://trac.edgewall.org/ticket/3361>
The Trac Project <http://trac.edgewall.com/>