[Trac-tickets] [The Trac Project] #2882: Missing TABLE end tag when viewing a file in Trac browser messes up display

[The Trac Project]

#2882: Missing TABLE end tag when viewing a file in Trac browser messes up display
-----------------------+----------------------------------------------------
 Reporter:  anonymous  |       Owner:  jonas
     Type:  defect     |      Status:  new  
 Priority:  normal     |   Milestone:       
Component:  browser    |     Version:  0.9.4
 Severity:  normal     |    Keywords:       
-----------------------+----------------------------------------------------
 '''Background'''

 Viewing a file (revision) in the code browser, an HTML preview of the file
 is generated if possible in templates/browser.cs:

 (around line 98)
 {{{
 if:!browser.is_dir ?>
   <div id="preview"><?cs
    if:file.preview ?><?cs
 }}}


 '''BUG'''

 The problem is that {{{<?cs var:file.preview ?>}}} does not properly end
 the generated HTML preview with a closing TABLE tag, which messes up the
 display of the file in a WWW browser such as Firefox or IE.

 I don't know where the cause of the error (the "implementation" of the
 ClearSilver tag {{{var:file.preview}}} above) is located, but I hope this
 information is sufficient.

 '''EXPECTED'''

 A properly formatted HTML preview of the file is generated.


 '''Workaround'''

 Modify {{{templates/browser.cs}}} at around line 101 as follows:

 Change
 {{{
     var:file.preview ?><?cs
 }}}

 To
 {{{
     var:file.preview ?></table><?cs
 }}}

-- 
Ticket URL: <http://projects.edgewall.com/trac/ticket/2882>
The Trac Project <http://trac.edgewall.com/>