[Trac] Database Patch 13 available

[Brad Anderson]

Christopher Lenz wrote:

<snip>

> 
> 
> This looks cool, I like how the size of the patch has dropped 
> significantly ;-)

The more you put into the trunk, and the more I refactor, it drops the 
size.  I had been noticing, too :)

> Thanks a *lot* for keeping to work on this patch all this time, I know 
> it must have been a pain.
> 
> Just two points/questions:
> 
> 1) IIUC you've not adopted the SQLObject syntax for specifying the 
> connection parameters. Any reason for that?

I think it's pretty close.  Postrgres & SQLite take only a string, and 
other dbms's that we haven't dealt with yet use keyword arguments.

http://sqlobject.org/docs/SQLObject.html#dbconnection-database-connections

What were you thinking, or how should I approach?

> 
> 2) Is there a windows-equivalent for `createdb`?

It's probably the same app, but that's not the problem.  It's in the 
calling of the command-line app.  I used the following code block:

         try:
             # TODO: this is not cross-platform.
             # for Windows, look at win32pipe.popen()
             os.popen(createdb_str)
         except Exception, e:
             print "Error creating PostgreSQL database: %s" % e
             print "command: %s" % createdb_str

and wanted to get some thoughts/help before I added the Win32 portion. 
I don't have a Win32 box with PG on it to test.


Ken Gunderson has already found some bugs in Patch 13, having to do with 
SQL statements in trac-admin, so I'll be taking a look at those.  There 
are also some bugs that may have to do with the SCM code you just put in 
(blank repos maybe?).  I'll let you know.

BA